Skip to content

Added WorkloadIdentityCredential#28536

Merged
xiangyan99 merged 20 commits intomainfrom
identity_workload_identity
Feb 1, 2023
Merged

Added WorkloadIdentityCredential#28536
xiangyan99 merged 20 commits intomainfrom
identity_workload_identity

Conversation

@xiangyan99
Copy link
Copy Markdown
Member

No description provided.

@xiangyan99 xiangyan99 requested a review from chlowell January 31, 2023 00:45
@ghost ghost added the Azure.Identity label Jan 31, 2023
@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Jan 31, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

Comment thread sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/workload_identity.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/workload_identity.py Outdated
Comment thread sdk/identity/azure-identity/CHANGELOG.md Outdated
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/workload_identity.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/managed_identity.py Outdated
xiangyan99 and others added 7 commits January 31, 2023 13:14
…ad_identity.py

Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
…ad_identity.py

Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/default.py
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/default.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/aio/_credentials/default.py Outdated
…t.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
…fault.py

Co-authored-by: Charles Lowell <10964656+chlowell@users.noreply.github.com>
@xiangyan99 xiangyan99 merged commit 2d61792 into main Feb 1, 2023
@xiangyan99 xiangyan99 deleted the identity_workload_identity branch February 1, 2023 23:32
@petergaultney
Copy link
Copy Markdown

petergaultney commented Feb 5, 2023

did the SDK support Workload Identity in some other form before this PR was merged? I'm using 1.12 on an AKS cluster with Workload Identity enabled and it seems to be working.... but now I see that the code for it apparently does not even exist in a released version?

EDIT: it looks like it was supported previously by token_exchange.py and used within managed_identity.py and you're just pulling it out into a separate credential within the Default chaini.

@xiangyan99
Copy link
Copy Markdown
Member Author

@petergaultney Yes. You are absolutely right! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants